Introduced new HG attribute 'monitor_slave_lag_when_null' which takes precedence over 'mysql_thread_monitor_slave_lag_when_null' #4528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p settings, which takes precedence over 'mysql_thread_monitor_slave_lag_when_null' if both are configured.
rahim-kanji
force-pushed
the
v2.x_monitor_slave_lag_when_null_4521
branch
from
bc2d29d
to
3ef9c5e
Compare
|
retest this please |
1 similar comment
|
retest this please |
|
Retest this please. |
|
retest this please |
These messages were introduced by #44678343, and got deprecated at the same time that 'admin-checksum_*' were deprecated (#d61d9892). Their original motivation is summarized in the following note: ``` LOGGING-NOTE: Log only if the remote checksum has just been updated. Avoids constant logging when 'global_checksum' are not used to prevent individual modules fetching. ``` These two messages mistakenly survived this deprecation with the introduction of table 'mysql_servers_v2'.
|
Retest this please. |
1 similar comment
|
Retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new hostgroup attribute 'monitor_slave_lag_when_null' in 'mysql_hostgroup_attibutes->hostgroup_settings', which takes precedence over 'mysql_thread_monitor_slave_lag_when_null' if both are configured.
Example usage:
INSERT INTO mysql_hostgroup_attributes (hostgroup_id, hostgroup_settings) VALUES (1, '{"monitor_slave_lag_when_null": 100}');Note:
* Permitted values for 'mysql-monitor_slave_lag_when_null' also apply to the 'monitor_slave_lag_when_null' attribute.
* If 'Seconds_Behind_Master' is negative, it will bring previously shunned server, due to replication lag, back online.
* True 'Seconds_Behind_Master' values returned by the server will be logged in 'mysql_server_replication_lag_log table. (Previously negative values were logged as null)
Closes #4521