Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several Cluster memory leaks #4546

Merged
merged 21 commits into from
May 17, 2024
Merged

Fix several Cluster memory leaks #4546

merged 21 commits into from
May 17, 2024

Commits on May 14, 2024

  1. Fix memory leak in 'pull_mysql_query_rules_from_peer' 

    - Simplified memory managament in Cluster credentials API.
- Moved several variables into local scopes.
    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    cf7da4e View commit details
    Browse the repository at this point in the history

  2. Fix memory leak on GTID 'new_connector'

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    317ef31 View commit details
    Browse the repository at this point in the history

  3. Fix memory leak on 'pull_mysql_query_rules_from_peer' statements

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    742ad8a View commit details
    Browse the repository at this point in the history

  4. Remove commented code from original GTID impl

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3e8d672 View commit details
    Browse the repository at this point in the history

  5. Remove commented code from original Cluster POC

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d9430ff View commit details
    Browse the repository at this point in the history

  6. Replace commented code on Cluster timeouts with comments

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2b1d576 View commit details
    Browse the repository at this point in the history

  7. Fix un-initialized variable 'all_modules_started'

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    80c30d7 View commit details
    Browse the repository at this point in the history

  8. Several improvements for 'test_backend_conn_ping' 

    - Improved test documentation, including doc about ProxySQL backend
  connection pinging algorithm.
- Fixed math for working with different number of threads.
- Fixed estimations for number of backend connections that should be
  maintained, and test goal.
- Fixed test early return. The test original goal was monitoring the
  number of connections maintained during an interval, ensuring the
  behavior was consistent during multiple checks. Any early return or
  shortcut defeats this purpose, this has increased the test duration.
- Added more overloads for helper function 'ext_single_row_val'.
- Improved logging.
    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8c83dac View commit details
    Browse the repository at this point in the history

  9. Several improvements for 'test_cluster_sync-t' 

    - Fix race condition on 'check_module_checksums_sync'.
- Replaced hardcoded value for CHECKSUM_SYNC_TIMEOUT in favor of
  computation.
- Added extra logging to synchronization checks.
    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c6fb194 View commit details
    Browse the repository at this point in the history

  10. Several improvements for test 'eof_packet_mixed_queries' 

    - Improved logging on error handling.
- Fixed replication issues in the presence of query rules.
    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e930d98 View commit details
    Browse the repository at this point in the history

  11. Minor cleanup in some TAP tests 

    - Removed unused dependencies.
- Removed commented code.
    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b86bbae View commit details
    Browse the repository at this point in the history

  12. Mitigate invalid memory accesses from Monitor GR on 'SHUTDOWN SLOW'

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    19e4ac2 View commit details
    Browse the repository at this point in the history

  13. Fix compilation for Centos 7

    @JavierJF
    JavierJF committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f8fb6fd View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Fix crashes during shutdown due to uninitialized 'AdminHTTPServer'

    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f962d13 View commit details
    Browse the repository at this point in the history

  2. Fix shutdown crashes due to 'debug_filters' destruction

    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    54ca795 View commit details
    Browse the repository at this point in the history

  3. Fix race condition on 'test_cluster_sync-t'

    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    abaea17 View commit details
    Browse the repository at this point in the history

  4. Increase logging for 'test_cluster_sync-t'

    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6a77d7d View commit details
    Browse the repository at this point in the history

  5. Increase tolerance of 'reg_test_3765_ssl_pollout' for ASAN builds

    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d7f2c44 View commit details
    Browse the repository at this point in the history

  6. Increase tolerance of 'test_cacert_load_and_verify_duration-t' for AS… 

    …AN builds
    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f867451 View commit details
    Browse the repository at this point in the history

  7. Increase timeouts of 'restapi_return_codes-t' for ASAN builds

    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    63968d6 View commit details
    Browse the repository at this point in the history

  8. Further increase timeouts of 'restapi_return_codes-t' for ASAN builds 

    Added doc elaborating on the limitation.
    @JavierJF
    JavierJF committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3d185ec View commit details
    Browse the repository at this point in the history