Fix value on first fetch for connpool prometheus metrics #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial value for metrics using 'p_update_connection_pool_update_*' helpers were missing. This only affects to the first metrics fetch, during the metric creation on the internal maps, subsequent fetches will find the already created metric and updated the value properly. As real counters are internal, this doesn't affect the correctness of the value in subsequent fetches.
A issue was also fixed on test utilities for metrics parsing.
JavierJF
force-pushed
the
v2.x-fix_connpool_metrics_init_val
branch
from
7cb5d78
to
99afddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor inaccuracy present in the first fetch performed to connection pool
prometheusmetrics. The initial value for metrics usingp_update_connection_pool_update_*helpers were missing.This only affects to the first metrics fetch, during the metric creation on the internal maps, subsequent fetches will
find the already created metric and updated the value properly. As real counters are internal, this doesn't affect the correctness of the value in subsequent fetches.
The PR also improves
prometheusmetrics test with new checks for these metrics.