-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.x logging mem [WIP] #4713
Open
renecannao
wants to merge
18
commits into
v2.7
Choose a base branch
from
v2.x-logging_mem
base: v2.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V2.x logging mem [WIP] #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept a reference to a vector instead of returning a deque
MySQL_Logger::insertMysqlEventsIntoDb() populate table `stats_mysql_query_events` using mysql query events in the circular buffer
MySQL_Logger::processEvents() is responsible for dumping mysql query events from the circular buffer into SQLite tables. DUMP EVENTSLOG commands trigger a call to processEvents(): * DUMP EVENTSLOG FROM BUFFER TO MEMORY: copies events to the in-memory SQLite table * DUMP EVENTSLOG FROM BUFFER TO DISK: copies events to the on-disk SQLite table * DUMP EVENTSLOG FROM BUFFER TO BOTH: copies events to both in-memory and on-disk SQLite tables simultaneously
Added new Admin variable stats_mysql_eventslog_sync_buffer_to_disk . This variable defines how frequently mysql query eventslog are automatically dumped to disk.
In MySQL_Event copy constructor, queries are copied up to eventslog_buffer_max_query_length bytes.
Added enhancements: * added mysql-eventslog_table_memory_size * liste columns names in insertMysqlEventsIntoDb() * added counters and metrics (not exported yet)
Added function MySQL_Logger::getAllMetrics() to export all metrics related to eventlogs
Adding logging for errors generated directly directly by ProxySQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.