Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport sql_mode and time_zone to 1.3.x #972

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Backport sql_mode and time_zone to 1.3.x #972

merged 1 commit into from
Mar 28, 2017

Conversation

minichate
Copy link
Contributor

I believe this brings #816 to the 1.3.x branch.

@renecannao renecannao merged commit dba6db1 into sysown:v1.3.5 Mar 28, 2017
@renecannao
Copy link
Contributor

Almost identical to 902e9d6 , so seems OK to merge.
Thanks

@jkklee
Copy link

jkklee commented Apr 24, 2017

@renecannao As far as i test, 1.3.6 can't process

# from wireshark
Command: Prepare Statement (22)
Statement: set session sql_mode=''

correctly.

1.3.4 and 1.3.5 seems ok.

@renecannao
Copy link
Contributor

@jkklee : yeah ... prepared statements.
This commit doesn't probably work with PS

@jkklee
Copy link

jkklee commented Apr 25, 2017

@renecannao
You mean, before 1.3.6, proxysql didn't track set sql_mode (or do nothing about sql_mode) at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@minichate @renecannao @jkklee