Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cargo-xbuild with build-std #9

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Replace cargo-xbuild with build-std #9

merged 1 commit into from
Jul 13, 2020

Conversation

crawfxrd
Copy link
Member

Use build-std instead of cargo-xbuild. This requires adding a dependency on rlibc, since the mem feature of compiler_builtins cannot be enabled [1].

@crawfxrd
Copy link
Member Author

This allows removing the compiler-builtins workaround. However, it's already set to the latest possible version we can currently use (before the switch to llvm_asm!()), so it it worth adding?

@crawfxrd crawfxrd marked this pull request as ready for review July 13, 2020 19:23
@crawfxrd crawfxrd requested a review from jackpot51 July 13, 2020 19:23
@jackpot51 jackpot51 merged commit 84ca337 into master Jul 13, 2020
@jackpot51 jackpot51 deleted the build-std branch July 13, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpot51 jackpot51 jackpot51 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crawfxrd @jackpot51