v252 batch #430
Merged
v252 batch #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When watching a given pathspec, systemd unconditionally installs IN_ATTRIB watches to track the link count of the resolved file. This way, we are notified if the watched path disappears, even if the resolved file inode is not removed. Similarly, systemd installs inotify watches on each parent directory, to be notified when the specified path appears. However, for these watches IN_ATTRIB is an unnecessary addition to the mask. In inotify, IN_ATTRIB on a directory is emitted whenever the attributes of any child changes, which, for many paths, has the potential to cause a high number of spurious wakeups in systemd. Let's remove IN_ATTRIB from the mask when installing watches on the parent directories of the specified path. (cherry picked from commit 8bf8c7d83dcffffa55b5f534fb98db6b01315dc1) (cherry picked from commit fa2b2da1466ff225363c1a0492b1b43c1d01dd8a) (cherry picked from commit 2818d5a) (cherry picked from commit e9db267) (cherry picked from commit 8f85d9c)
Symlink created by Alias will use the value as the file name. (cherry picked from commit 3f0e7fd4fd1d20e3f4be18f485c76d25ce10f41b) (cherry picked from commit a68188e985d29e46cfa6eb2e17419fad90f0b287) (cherry picked from commit 4b8ce6a) (cherry picked from commit e8566d7) (cherry picked from commit 0179fb5)
This is a common case, and nothing noteworthy at all. For example, if we establish an enumerator for listing all devices tagged by some tag, then the per-tag dir is not going to exist if there are currently no devices tagged that way, but that's a really common case, and doesn't really deserve any mention, not even at debug level. (cherry picked from commit a68c97a54527cacaeeac0c117493639fc455ef5e) (cherry picked from commit 8aa9e60f89f84a90fb364ee66cf62432a6b877ba) (cherry picked from commit a321caf) (cherry picked from commit 32a3200) (cherry picked from commit 9988e09)
Make the warning for oneshot services (where RuntimeMaxSec= has no effect) more actionable by pointing to the directive people can use instead to effectively limit their runtime. (cherry picked from commit 8c4aa0f1c6a78b35712fa6a7acf6d755d0c0bd86) (cherry picked from commit 468b0646342986c6cc9bd797b4ba189dc488ee8d) (cherry picked from commit 017d7fd) (cherry picked from commit a7e6ebc) (cherry picked from commit 7b09e91)
If there is an error with the execv call in fork_agent the program exits without any meaningful log message. Log the command and errno so the user gets more information about the failure. Fixes: #33418 Signed-off-by: Mauri de Souza Meneguzzo <[email protected]> (cherry picked from commit a408d4453145621902b9a3ef78a552f83b09bd8d) (cherry picked from commit 7fcfb73d71ed1d4230f58de1a94790e0c28719ea) (cherry picked from commit 76fe6eb) (cherry picked from commit 084b911) (cherry picked from commit b9a08c7)
We'll *always* hit ENEOENT when iterating through SMBIOS type systemd#11 fields, on the last one. it's very confusing to debug log about that, let's just not do it. (cherry picked from commit 5202ee42d5da0ae3a6655d2bc959a19d8c347e9d) (cherry picked from commit 995c702a347d16cfad4605f3982d5278616ea1f8) (cherry picked from commit f084959) (cherry picked from commit b5f3e79) (cherry picked from commit 62f8196)
Follow-up for 6906c02 The mentioned commit uses access() to check if varlink socket already exists in the filesystem, but that isn't sufficient. > Varlink sockets are not serialized until v252, so upgrading from > v251 or older means we will not listen anymore on the varlink sockets. > > See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1074789 > for more details as this was found when updating from Debian Bullseye to a new version. After this commit, the set up of varlink_server is effectively split into two steps. manager_varlink_init_system(), which is called after deserialization, would no longer skip listening even if Manager.varlink_server is in place, but actually check if we're listening on desired sockets. Then, manager_deserialize() can be switched back to using manager_setup_varlink_server(). Alternative to #33817 Co-authored-by: Luca Boccassi <[email protected]> (cherry picked from commit d4e5c66ed469c822ca5346c7a445ec1446b1d17f) (cherry picked from commit b825a8be0b7b857a715e982cee861e8ae6995ee8) (cherry picked from commit 3b3875e) (cherry picked from commit e7155d8) (cherry picked from commit 69985ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.