Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sudo to disallow root permission #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,8 @@ COPY root/ /
EXPOSE 8080 8443
VOLUME ["/config","/vaults"]

# Remove sudo
RUN rm /usr/bin/sudo

# Define a healthcheck
HEALTHCHECK CMD curl --fail http://localhost:8080/ || exit 1
2 changes: 1 addition & 1 deletion root/defaults/autostart
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sudo /usr/bin/obsidian --no-sandbox --no-xshm --disable-dev-shm-usage --disable-gpu --disable-software-rasterizer
/usr/bin/obsidian --no-sandbox --no-xshm --disable-dev-shm-usage --disable-gpu --disable-software-rasterizer
2 changes: 1 addition & 1 deletion root/defaults/menu.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<menu id="root-menu" label="MENU">
<item label="Obsidian" icon="/usr/share/icons/hicolor/48x48/apps/obsidian.png">
<action name="Execute">
<command>sudo /usr/bin/obsidian --no-sandbox</command>
<command>/usr/bin/obsidian --no-sandbox</command>
</action>
</item>
<item label="xterm" icon="/usr/share/pixmaps/xterm-color_48x48.xpm">
Expand Down