Fix android12/13 crash #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what the interaction is exactly -- maybe ndk related, maybe to do with the old opencv version (4.4) we're still on -- but being on 32/33 causes consistent crashes on Android 12/13 (observed on Samsungs, possibly on others).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #14.
There's a mysterious interaction between setting
targetSdkVersion>= 32 and (libcimbar and) either the old NDK version or the old opencv version that results in a consistent crash. My wild guess is it's the NDK, but the upshot should be:targetSdkVersionto >= 32. 🙃Misc notes, NDK upgrade edition:
22.1.7171670-- I ran into issues with 23.x, and pretty noticeable bad performance with 24.x)Misc notes, opencv upgrade edition: