Fix memory corruption bug + misc other libcimbar updates #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idea is to count partial decodes and full decodes separately, and maybe provide visual feedback to the user based on that. Not clear how well it works...
368c2c4ed Merge pull request #90 from sz3/bugfix-santitize-future 258991bc1 Fix some longstanding (no)-fsanitize sloppiness e77b598f2 Merge pull request #89 from sz3/bugfix-flood-decode-bounds-check ead73ea63 fix memory corruption bug 0fe367f27 Fix the error check in FloodDecodePositions 97f4af38b Merge pull request #87 from sz3/build-and-css-bugfix-24-2 0f2d7188a Tweak to make package-portable-linux slightly less docker dependent d2ddcc214 Use innerWidth to avert android firefox shenanigans 8f9caa18b If negative z-index is bad vibes, we should set z-index+1 various places 38b8068e8 Update index.html 01193747e Merge pull request #85 from sz3/pin-cmake-portable-build 452eb716d Pin "portable" linux script to use an old (known good) cmake 05d5e3891 Merge pull request #82 from sz3/ios-css-bugfix 69a7d415e Fix bug/change in ios (un)focus behavior? git-subtree-dir: app/src/cpp/libcimbar git-subtree-split: 368c2c4edaf66802863c3798ad850b30469b5f2b
Off by one, memory corruption, we got it all... #29 sz3/libcimbar#89 sz3/libcimbar#90 Thanks to @notune for the AdjacentCellFinder fix! Co-authored-by: Noah<[email protected]>
sz3
commented
Feb 10, 2024
| cv::Scalar color = in_progress? cv::Scalar(0,255,0) : cv::Scalar(255,255,255); | ||
| cv::Scalar color = cv::Scalar(255,255,255); | ||
| if (in_progress == 1) | ||
| color = cv::Scalar(255,100,100); |
There was a problem hiding this comment.
Adding visual feedback for when extracts are happening, but decodes aren't.
The color is red right now -- I might change it. (green = success)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be 0.15.5, the lasthopefully of the 0.5.x releases.
Includes #29 by way of sz3/libcimbar#89