Fixes for cimbar.js, cimbar_send #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you know wtf this nonsense is about, send me a message
sz3
commented
Jun 10, 2023
| @@ -23,7 +23,7 @@ jobs: | |||
| - name: Run the build process with Docker | |||
| uses: addnab/docker-run-action@v3 | |||
| with: | |||
| image: emscripten/emsdk:latest | |||
| image: emscripten/emsdk:3.1.39 | |||
There was a problem hiding this comment.
Staying on latest isn't just tempting fate: it's already changed/broken in the past month.
sz3
commented
Jun 10, 2023
| if (width % 4 != 0) | ||
| width += (4 - width % 4); | ||
| if (height % 4 != 0) | ||
| height += (4 - height % 4); |
There was a problem hiding this comment.
I'll admit I don't understand this at all. Some opengl nonsense, I think.
sz3
commented
Jun 10, 2023
| if (ecc < 0 or ecc >= 150) | ||
| ecc = 30; | ||
| ecc = cimbar::Config::ecc_bytes(); |
sz3
commented
Jun 10, 2023
| @@ -157,7 +157,7 @@ return { | |||
|
|
|||
| setColorBits : function(color_bits) | |||
| { | |||
| Module._configure(color_bits, 30, 6); | |||
| Module._configure(color_bits, 255, 255); | |||
sz3
added a commit
that referenced
this pull request
Mar 13, 2024
f219e87 Merge pull request #75 from sz3/web-fix 20f1601 The GL window height, or width, or both, needs to be divisible by 4? 98368d7 Pass dummy values to configure() to use config defaults 1b09a77 Use Config settings for cimbar_js defaults b392e57 Pin the emscripten/emsdk docker image d9bd2a2 Merge pull request #73 from sz3/bugfix-improve-and-5x5 709a348 Add back a few test cases, add some comments, and check in the 5x5 tileset b9d9d03 Simplify calculate_cooldown() + a comment for FloodDecodePositions::update() 55fcadb gh workflow updates 6baf0c4 Odd emscripten workaround -- not sure if this is the "right way", but it works 9f11473 Fix wasm packaging script 04528bb Add the 5x5 tileset to bitmaps.h + missing include dce6833 Fix off-by-one type bug! d452652 Update regression tests 8c891d0 Put back the Config.cpp for broader compiler support... 55956de Update more tests? 9204892 Misc fix 4d2943c Experimenting with ways to improve the flood decode 6daa947 3,-5 for adaptiveThreshhold on symbols seems better? 18e5480 Put back the skip param for mean_rgb on larger cell sizes 1ec077b Running afoul of constexpr rules 4e33841 Put us back on 8x8 ec74f7c For now, put the uint128s back 02d4573 Have ahash_result take a template param for cell size e2b55fc + do all bitextract index magic in "pattern()" function 24a291a Add some compile-time magic to auto-generate the bit extract pattern 173087c Move grid params into their own file? cad107c Minor tweaks to make it easier to switch between grid sizes f932602 Special case for running the "ALL" check (9-way compare) on seed locations 92a33ef More warnings \o/ 3479d39 Better(?) threshold params, and a thought 99e0f51 Drift cooldown? f3cdabe More const, and add more seed positions for the decode? 6849234 These should all be const... f9a9dd8 Scale window size off the size of the image. 3616c36 Pass image_size/anchor_size to extractor... 7766cfd Attempt to use 988x988 grid...? c4f8750 A 5x5 that works with both 4 bit and 5 bit c34ae88 Calculate total_cells() and frame capacity, and ... cdd2f5c Update ahash_result for 5-bit reads + lots of test fixes for average_hash ec62980 Changes to average_hash... e2cab43 Small changes to average_hash(), decode_color() 731dfb1 Update the bitextractor to deal with reads other than len=8 1fd265d Minimal changes for encoding with a grid of 5x5s b0aae78 Merge pull request #68 from sz3/packaging-cimbar-html 6ca0650 Post cimbar_js.html as part of package build. 0906f68 Script to bundle cimbar_js's asm.js build into a single html file c8529e3 Merge pull request #63 from sz3/stdin d17dcf3 -f is now the default 21f9932 A bit silly, but: py3.6 compatibility for now 2ff867d Test cli? d646ec7 Have fountain_decoder_sink optionally print its work... 892579a Have the encoder be stdin-aware too 21cc6a7 🤔 aad249d Read filenames from stdin iff no inputs are provided, + ... 074d813 Make fountain encoding the default. Add StdinLineReader for decodes. 89762c1 An idea git-subtree-dir: app/src/cpp/libcimbar git-subtree-split: f219e87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including pinning the emscripten emsdk image...