Skip to content

Commit

Permalink
[SPARK-48237][BUILD] Clean up dev/pr-deps at the end of `test-depen…
Browse files Browse the repository at this point in the history 
…dencies.sh` script

### What changes were proposed in this pull request?
The pr aims to delete the dir `dev/pr-deps` after executing `test-dependencies.sh`.

### Why are the changes needed?
We'd better clean the `temporary files` generated at the end.
Before:
```
sh dev/test-dependencies.sh
```
<img width="569" alt="image" src="https://github.com/apache/spark/assets/15246973/39a56983-774c-4c2d-897d-26a7d0999456">

After:
```
sh dev/test-dependencies.sh
```
<img width="534" alt="image" src="https://github.com/apache/spark/assets/15246973/f7e76e22-63cf-4411-99d0-5e844f8d5a7a">

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Manually test.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#46531 from panbingkun/minor_test-dependencies.

Authored-by: panbingkun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit f699f55)
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit d8c9b542902aabe5eb6cb682953f00ccf3fa891e)
  • Loading branch information
@panbingkun
panbingkun authored and Huaxin Gao committed May 22, 2024
1 parent 0daeba0 commit 834fdf6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions dev/test-dependencies.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,8 @@ for HADOOP_HIVE_PROFILE in "${HADOOP_HIVE_PROFILES[@]}"; do
fi
done

if [[ -d "$FWDIR/dev/pr-deps" ]]; then
rm -rf "$FWDIR/dev/pr-deps"
fi

exit 0

0 comments on commit 834fdf6

Please sign in to comment.