Skip to content
This repository has been archived by the owner on Feb 23, 2019. It is now read-only.

YUI Compressor: Fix for Empty JAVA executable path and JAVA path with spaces #426

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

nigrosimone
Copy link
Collaborator

@nigrosimone nigrosimone commented Feb 27, 2017

Two fix here.

  1. W3TC on "Test YUI Compressor" always return "Empty JAVA executale path"

2017-02-26_1559

  1. If java path has spaces (very common on windows) doesn't works

immagine2

@nigrosimone nigrosimone merged commit 466bda3 into v0.9.5.x Feb 27, 2017
@nigrosimone nigrosimone deleted the yui-compressor branch February 27, 2017 20:06
@MakarkinPRO
Copy link

How to apply that Fix to my W3 total cache plugin?

@nigrosimone
Copy link
Collaborator Author

nigrosimone commented Mar 1, 2017

@MakarkinPRO sorry for the delay. You have some options:

  1. you can replicate the same change here https://github.com/szepeviktor/w3-total-cache-fixed/pull/426/files on your website in the same files in the same way.

  2. you can download these files and replace on your website in /wp-content/plugins/w3-total-cache/:

  1. you can install W3 Total Cache Fixed instead of W3 Total Cache. Download the master, and follow this steps for install it https://github.com/szepeviktor/w3-total-cache-fixed#installation-for-v095x-users . This community version has some others bug fix see: https://github.com/szepeviktor/w3-total-cache-fixed/wiki/Changelog.

@MakarkinPRO
Copy link

Thx. Cool manual for me!

@MakarkinPRO
Copy link

Looks like still have same issue (follow step 2)

@nigrosimone
Copy link
Collaborator Author

try to delete your browser cache for use the fresh version of pub/js/options.js.

@MakarkinPRO
Copy link

Heh. Yes. That works! Just last 2 questions YUI work good with NGINX and it's the best for CSS/JS minifing?

@nigrosimone
Copy link
Collaborator Author

YUI work good with NGINX

Yui isn't a webserver's tool: it works on nginx, apache and iis without any difference.

it's the best for CSS/JS minifing?

I don't know if it's the best, but it's good.

@MakarkinPRO
Copy link

When I'm activating it all my Site looks ugly probably becaouse CSS and JS not loaded correctly) But it's loading faster)

@nigrosimone
Copy link
Collaborator Author

I think yui fails in minification. Sometime if yui try to minify already minified file it fails. in this case the only option is use standard minifier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants