Skip to content
This repository has been archived by the owner on Feb 23, 2019. It is now read-only.

Fix all querystring keys starting with name specified will match #489

Merged
merged 2 commits into from
May 21, 2017

Conversation

nigrosimone
Copy link
Collaborator

@nigrosimone nigrosimone commented May 21, 2017

This pr fix the issue where all querystring keys starting with name specified will match the accepted query strings.

If the user add the key foo, the rule all querystring keys starting with foo, eg.: foobar.

This happen because at line:

$val .= ( strpos( $val, '=' ) === false ? '.*?' : '' );

the rule become
foo.*?
instead of
foo=.*?

the simple fix is add a = into the rule, eg.:

$val .= ( strpos( $val, '=' ) === false ? '=.*?' : '' );

now, the rule become:
foo=.*?

Main PR is #380

@nigrosimone nigrosimone merged commit 1f24dc8 into v0.9.5.x May 21, 2017
@nigrosimone nigrosimone changed the title Fix accept qs Fix all querystring keys starting with name specified will match May 21, 2017
@nigrosimone nigrosimone deleted the fix-accept-qs branch May 21, 2017 10:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant