This repository has been archived by the owner on Feb 23, 2019. It is now read-only.
Fix a timeout update that was missed in push CDN upload PR #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier PR, szepeviktor#452, Fixed several bugs in the code for uploading files to push CDNs, including increasing timeouts for uploading chunks of files, since five seconds wasn't nearly enough in many cases. Unfortunately, one of the timeouts that needed to be increased was missed. This fixes that missed timeout so it matches the others.
Merged
Furniel
pushed a commit
that referenced
this pull request
Dec 24, 2017
An earlier PR, #452, Fixed several bugs in the code for uploading files to push CDNs, including increasing timeouts for uploading chunks of files, since five seconds wasn't nearly enough in many cases. Unfortunately, one of the timeouts that needed to be increased was missed. This fixes that missed timeout so it matches the others.
Furniel
pushed a commit
that referenced
this pull request
Jul 3, 2018
An earlier PR, #452, Fixed several bugs in the code for uploading files to push CDNs, including increasing timeouts for uploading chunks of files, since five seconds wasn't nearly enough in many cases. Unfortunately, one of the timeouts that needed to be increased was missed. This fixes that missed timeout so it matches the others.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier PR, #452,
Fixed several bugs in the code for uploading files to push CDNs,
including increasing timeouts for uploading chunks of files, since
five seconds wasn't nearly enough in many cases. Unfortunately, one of
the timeouts that needed to be increased was missed. This fixes that
missed timeout so it matches the others.