Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canvasContextOptions API for use by the getContext #761

Merged
merged 7 commits into from
Mar 10, 2024
Merged

Add canvasContextOptions API for use by the getContext #761

merged 7 commits into from
Mar 10, 2024

Conversation

stsrki
Copy link
Contributor

@stsrki stsrki commented Mar 9, 2024

Closes #760

@stsrki
Copy link
Contributor Author

stsrki commented Mar 9, 2024

I added the willReadFrequently option to be passed to the canvas.getContext. Since the name willReadFrequently might be too generic, I propose renaming it to

  • willReadCanvasFrequently, or
  • willReadContextFrequently, or
  • willReadCanvasContextFrequently

@UziTech
Copy link
Collaborator

UziTech commented Mar 9, 2024 •
edited
Loading

I think it would be better to have a canvasContextOptions instead of each option. That way when Chrome adds more options we won't need to change anything.

@stsrki
Copy link
Contributor Author

stsrki commented Mar 9, 2024

I think it would be better to have a canvasContextOptions instead of each option. That way when Chrome adds more options we won't need to change anything.

Makes sense. I will make the changes.

@stsrki stsrki changed the title Add willReadFrequently to getContext Add canvasContextOptions API for use by the getContext Mar 9, 2024
@stsrki
Copy link
Contributor Author

stsrki commented Mar 9, 2024 •
edited
Loading

I have updated the API and add canvasContextOptions.

UziTech
UziTech requested changes Mar 10, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stsrki stsrki requested a review from UziTech March 10, 2024 07:48
UziTech
UziTech approved these changes Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@UziTech UziTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@UziTech UziTech merged commit 7abdd48 into szimek:master Mar 10, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 10, 2024
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
9ec285e 
# [4.2.0](v4.1.7...v4.2.0) (2024-03-10)

### Features

* add canvasContextOptions API for use by the getContext ([#761](#761)) ([7abdd48](7abdd48))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stsrki stsrki deleted the feat/will-read-frequently branch March 10, 2024 12:39
@stsrki
Copy link
Contributor Author

stsrki commented Mar 10, 2024

Thank you for merging this feature. Much appreciated 🙏

@agilgur5 agilgur5 mentioned this pull request Jul 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the willReadFrequently in getContext
2 participants
@stsrki @UziTech