[FEATURE] Google Tag Manager #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websi
reviewed
Oct 11, 2017
| @@ -0,0 +1,21 @@ | |||
| # Google Analytics track pageview and add script for event tracking | |||
| [globalString = LIT:{$themes.configuration.tracking.ga_gtmid} = /(GTM)-[a-zA-Z0-9]+/] | |||
There was a problem hiding this comment.
Can we use an implementation without TYPO3 conditions.
These problem can be solved with an TypoScript if.
Every Condition is a performance problem.
Every condition is evaluated at every request.
An if is only evaluated once and the result is cached.
There was a problem hiding this comment.
Can you provide an example how you want to implement it?
There was a problem hiding this comment.
page.headerData.17895 = TEXT
page.headerData.17895 {
value = ...
if.isTrue = {$themes.configuration.tracking.ga_gtmid}
}
page.3 = TEXT
page.3 {
value = ...
if.isTrue = {$themes.configuration.tracking.ga_gtmid}
}
See https://docs.typo3.org/typo3cms/TyposcriptReference/Functions/If/Index.html
The test with regex is not really needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.