[BUGFIX] adjust image height settings for news cards template #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be reverted because looks like this is not a proper fix for this #351 issue. Tested on t3kit default site. Images still wrongly scaled. Should be reviewed again. |
dmh
added a commit
that referenced
this pull request
Feb 15, 2018
dmh
pushed a commit
that referenced
this pull request
Jun 7, 2018
…mages. Accessibility * [FEATURE] revert "[BUGFIX] partly revert - improve news list accessibility (#343)" This reverts commit ed1b624. * [FEATURE] revert "[BUGFIX] revert - change markup for news list (#373)" This reverts commit a4286d0. * [FEATURE] revert "[BUGFIX] revert PR adjust image height settings for news cards template (#382)" This reverts commit b305f6a. * [FEATURE] revert "[BUGFIX] revert PR Improve news cards accessibility (#351)" This reverts commit 2d33074. * [FEATURE] revert "[BUGFIX] revert news-carousel accessibility improvements (#352)" This reverts commit f1b155e. * Issue #83227: Add object-fit polyfill and remove background images * update css/less * remove unnecessary tag to fix error * adjust less formatting for stylelint * update css/less * remove wrong indentation * update css/less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background image and dummy image should always have same height to avoid layout break.
Image height is set to 768px to fill column width in tablet viewport.