Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for image capture #11

Open
Hadryan opened this issue Jan 27, 2019 · 2 comments
Open

Support for image capture #11

Hadryan opened this issue Jan 27, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Hadryan
Copy link

Hadryan commented Jan 27, 2019

How to get the HTML <img> tag and its different attributes: src, alt, width, ....

@timqian timqian added the enhancement New feature or request label Jan 28, 2019
@timqian
Copy link
Member

timqian commented Jan 28, 2019

It should not be hard to support capturing <img/> tag, but how to display it the sSelected contents part and how to show API caller is a little tricky.

So maybe we display the image in the Selected contents part and add an imgSrc key in the API response?

    {
      "innerText":
      "href":
      "imgSrc":
    }

Do you have better ideas?

MathMesquita pushed a commit to MathMesquita/cloudquery that referenced this issue Feb 3, 2019
@MathMesquita
Copy link

Hello everyone, i've created a pull request for this feature, adopting the contract @timqian mentioned above...

But now i'm wondering about other changes in the project architecture we could make... Add tests, define a better contract(i don't think a list of "contents" based on the selectors order is the best approach for an API) etc...

I'll create a new issue to debate those topics :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants