Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dataserver connections aren't federated #87

Closed
benlower opened this issue Sep 29, 2016 · 1 comment
Closed

Dataserver connections aren't federated #87

benlower opened this issue Sep 29, 2016 · 1 comment
Assignees
@t8y8
Labels
bug

Comments

@benlower
Copy link
Contributor

Need to support changing connection string on data server datasources
@benlower benlower added the bug label Sep 29, 2016
@t8y8 t8y8 mentioned this issue Sep 30, 2016
Merged
@t8y8 t8y8 assigned t8y8 and unassigned graysonarts Sep 30, 2016
t8y8 added a commit that referenced this issue Sep 30, 2016
@t8y8
Fix #87 by working around non-federated sqlproxy connections (#89)
8228efa 
When Cross Database Joins were introduced in 10 all connections became "federated" by default, even if they weren't actually joined to anything else. 

In the file format that means they get represented as named-connection/connection elements. Expressed under one top-level connection element with a class of 'federated'.

Except for 'sqlproxy' connections (Published Data Sources) -- they stay in the old connection style as a top level connection element.

We need to, when in a 10.0 or greater workbook, get all federated connections (named-connection) plus go back and find any sqlproxy connections as well.
@t8y8
Copy link
Contributor

t8y8 commented Sep 30, 2016

Closed by #89

@t8y8 t8y8 closed this as completed Sep 30, 2016
graysonarts pushed a commit that referenced this issue Oct 7, 2016
@t8y8
Fix #87 by working around non-federated sqlproxy connections (#89)
a440256 
When Cross Database Joins were introduced in 10 all connections became "federated" by default, even if they weren't actually joined to anything else. 

In the file format that means they get represented as named-connection/connection elements. Expressed under one top-level connection element with a class of 'federated'.

Except for 'sqlproxy' connections (Published Data Sources) -- they stay in the old connection style as a top level connection element.

We need to, when in a 10.0 or greater workbook, get all federated connections (named-connection) plus go back and find any sqlproxy connections as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t8y8 t8y8

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@graysonarts @benlower @t8y8