Remove usage of deprecated property naming strategy CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ER_CASE_WITH_UNDERSCORES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are using
jackson-databindin version2.9.10.4which hasPropertyNamingStrategy.CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORESdeprecated and it's set toSNAKE_CASEanyway. So there is no need incom.taboola.rest.api.internal.serialization.SerializationMapperCreator#createObjectMapperto check if theSNAKE_CASEshould be used - in the current implementation thePropertyNamingStrategyis always set toSNAKE_CASE. Maybe even the whole fieldcom.taboola.rest.api.internal.config.SerializationConfig#shouldUseSnakeCasecould be deleted but I'm not sure so I didn't do that.The problem is that this field (
PropertyNamingStrategy.CAMEL_CASE_TO_LOWER_CASE_WITH_UNDERSCORES) has been removed in a newer version ofjackson-databindlibrary which we are using in our project.After applying this change there is need to bump version of
api-java-client-corein thebackstage-api-java-clientand release new version.