Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in 10 Commandments of Tact documentation #488

Closed
cemorum opened this issue Jun 26, 2024 · 0 comments · Fixed by #489
Closed

Typo in 10 Commandments of Tact documentation #488

cemorum opened this issue Jun 26, 2024 · 0 comments · Fixed by #489
Assignees
Labels
internal-documentation Internal documentation of the Tact compiler and the repository. Not to be confused with docs/
Milestone

Comments

@cemorum
Copy link
Contributor

cemorum commented Jun 26, 2024

The text provided is already quite comprehensive and well-written. However, there is a minor typo in the "10 Commandments of Tact" section, specifically in point 3. The word "lets" should be corrected to "lets you." Here's the improved line:

Original:
"Tact offers strong compile-time checks for contract interfaces, typed addresses and lets describe messages natively in a subset of TL-B."

Improved:
"Tact offers strong compile-time checks for contract interfaces, typed addresses and lets you describe messages natively in a subset of TL-B."

@anton-trunov anton-trunov added this to the v1.4.0 milestone Jun 26, 2024
@anton-trunov anton-trunov added the internal-documentation Internal documentation of the Tact compiler and the repository. Not to be confused with docs/ label Jun 26, 2024
@anton-trunov anton-trunov modified the milestones: v1.4.0, v1.4.1 Jun 26, 2024
7empty7 added a commit to 7empty7/tact that referenced this issue Jul 24, 2024
The address link (https://twitter.com/tact_language) specified in the code is not relevant, and therefore may affect further work, fix this issue with writing “https://x.com/tact_language”

I have updated tact.js

I have documented my contribution in Tact Docs: https://github.com/7empty7/tact

I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases

I have run all the tests locally and no test failure was reported

I did not do unrelated and/or undiscussed refactorings

Close tact-lang#488

UQB6EnIw0WdVKEnn4vIxc-RUX7cpauyJhxtJrhNhNWQ4EGM6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-documentation Internal documentation of the Tact compiler and the repository. Not to be confused with docs/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants