Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logical error in text.tact #603

Closed
Srg-12 opened this issue Jul 22, 2024 · 0 comments
Closed

Logical error in text.tact #603

Srg-12 opened this issue Jul 22, 2024 · 0 comments

Comments

@Srg-12
Copy link

Srg-12 commented Jul 22, 2024

The fromBase64 function contains a logical error in the if conditions used to check for specific characters. Instead of using the logical AND operator &&, the code uses the "||" to combine conditions. This will result in a syntax error.

Location:
Lines 74 and 76 of the "text.tact" document.
Srg-12 added a commit to Srg-12/tact that referenced this issue Jul 22, 2024
@Srg-12
Fix logical error in text.tact tact-lang#603
1e2c64b 
Edited:
Line tact-lang#74 From:
 } else if (code == 45 || code == 43) { // - or +
To:
 } else if (code == 45 && code == 43) { // - or +

Line tact-lang#76 From:
} else if (code == 95 || code == 47) { // _ or /
} else if (code == 95 && code == 47) { // _ or /
@Srg-12 Srg-12 mentioned this issue Jul 22, 2024
Closed
6 tasks
@anton-trunov anton-trunov closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logical error in text.tact #603 Srg-12/tact
2 participants
@anton-trunov @Srg-12