Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not informative internal compiler errors #670

Closed
Gusarich opened this issue Aug 9, 2024 · 0 comments · Fixed by #673
Closed

Not informative internal compiler errors #670

Gusarich opened this issue Aug 9, 2024 · 0 comments · Fixed by #673
Assignees
Milestone

Comments

@Gusarich
Copy link
Member

Gusarich commented Aug 9, 2024

#669 refactored internal compiler errors but also introduced a problem because of a small overlook. Some errors that are thrown without source location specified don't include the error message.

So it's now less informative in some cases. For example, when trying to compile non-existing project source:

💼 Compiling project getters ...
Tact compilation failed
Error
    at throwCompilationError (/Users/daniil/Coding/tact/src/errors.ts:91:11)
    at resolveImports (/Users/daniil/Coding/tact/src/imports/resolveImports.ts:28:30)
    at precompile (/Users/daniil/Coding/tact/src/pipeline/precompile.ts:18:36)
    at build (/Users/daniil/Coding/tact/src/pipeline/build.ts:73:25)
    at run (/Users/daniil/Coding/tact/src/node.ts:130:34)
    at async /Users/daniil/Coding/tact/scripts/prepare.ts:20:31
Error: Tact projects compilation failed
    at /Users/daniil/Coding/tact/scripts/prepare.ts:24:19
error Command failed with exit code 1.

while before it would throw Could not find entrypoint XXX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants