Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseImports: Return AST for Import nodes #965

Closed
jubnzv opened this issue Oct 16, 2024 · 0 comments · Fixed by #966
Closed

parseImports: Return AST for Import nodes #965

jubnzv opened this issue Oct 16, 2024 · 0 comments · Fixed by #966
Labels
api Tact's TypeScript API for third-party tools enhancement New feature or request good first issue Good for newcomers
Milestone
v1.6.0

Comments

@jubnzv
Copy link
Member

jubnzv commented Oct 16, 2024

The parseImports function should return a list of AstImport objects instead of just their string values:

tact/src/grammar/grammar.ts

Line 1457 in 2315d03

export function parseImports(

Needed for implementing the imports graph: #653, since we are interested to store as much information about imports as possible to share it to API users.
@jubnzv jubnzv added enhancement New feature or request good first issue Good for newcomers api Tact's TypeScript API for third-party tools labels Oct 16, 2024
@Esorat Esorat mentioned this issue Oct 16, 2024
Merged
5 tasks
@jubnzv jubnzv mentioned this issue Oct 17, 2024
Open
@anton-trunov anton-trunov added this to the v1.6.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Tact's TypeScript API for third-party tools enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

fix: return AST import nodes from parseImports instead of strings Esorat/tact
2 participants
@anton-trunov @jubnzv