Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return AST import nodes from parseImports instead of strings #966

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

Esorat
Copy link
Contributor

@Esorat Esorat commented Oct 16, 2024

Issue

Closes #965 .

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Esorat Esorat requested a review from a team as a code owner October 16, 2024 16:21
@anton-trunov anton-trunov self-assigned this Oct 16, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! You need to fix the type errors the linter warns you about (we have that "I have run the linter, formatter and spellchecker" checkbox for a reason).

Also, please add an entry to the changelog under the Changed section

CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov changed the title fix: adapt resolveImports to handle AstImport objects from parseImports fix: return AST import nodes from parseImports instead of strings Oct 17, 2024
@anton-trunov anton-trunov added this to the v1.6.0 milestone Oct 17, 2024
@anton-trunov anton-trunov merged commit 1510fbe into tact-lang:main Oct 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseImports: Return AST for Import nodes
2 participants