Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement string escaping and fix bug with error messages #192

Merged
merged 10 commits into from
Apr 2, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Mar 26, 2024

This PR resolves #25 and fixes #53

Supported escaping sequences:

  • \\
  • \"
  • \n
  • \r
  • \t
  • \v
  • \b
  • \f
  • \u{ABC}
  • \uABCD
  • \xAB

@anton-trunov anton-trunov self-assigned this Mar 26, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Let's support some more things though

src/grammar/grammar.ohm Outdated Show resolved Hide resolved
src/grammar/grammar.ohm Show resolved Hide resolved
novusnota
novusnota previously approved these changes Mar 28, 2024
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update CHANGELOG.md

@anton-trunov anton-trunov merged commit 3b5f211 into tact-lang:main Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract does not work if we have ` in throw message No possibility to escape characters in strings
3 participants