Implement local type inference for let statements
#198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusarich
force-pushed
the
local-type-inference
branch
from
2da1062
to
f26dd83
Compare
Gusarich
force-pushed
the
local-type-inference
branch
from
f26dd83
to
07cdc25
Compare
|
Let's fix the merge conflict in CHANGELOG and move the tests to their new location |
Gusarich
force-pushed
the
local-type-inference
branch
from
713da44
to
dd61f96
Compare
|
@anton-trunov done |
anton-trunov
requested changes
Jun 13, 2024
|
There is a case when local type inference should break: |
|
@anton-trunov everything's done! |
4 tasks
QwFRx
added a commit
to QwFRx/tact
that referenced
this pull request
Jul 22, 2024
In Roadmap.md there was a line "let". The mistake is that the first letter in the sentence should be capitalized. I suggest fixing this problem by writing "Let" instead of "let". Original: "let-statements can now be used without an explicit type declaration and determine the type automatically if it was not specified: PR tact-lang#198 and PR tact-lang#438" Improved: "Let-statements can now be used without an explicit type declaration and determine the type automatically if it was not specified: PR tact-lang#198 and PR tact-lang#438" Closes tact-lang#591 - [ ] I have updated CHANGELOG.md - [ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER - [ ] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases - [ ] I have run all the tests locally and no test failure was reported - [ ] I have run the linter, formatter and spellchecker - [ ] I did not do unrelated and/or undiscussed refactorings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #161