Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ast): Create named union types for fields of AST nodes #325

Merged
merged 6 commits into from
May 7, 2024
Merged

chore(ast): Create named union types for fields of AST nodes #325

merged 6 commits into from
May 7, 2024

Conversation

byakuren-hijiri
Copy link
Contributor

@byakuren-hijiri byakuren-hijiri commented May 6, 2024 •
edited
Loading

Addresses #314 (see this comment)

  • I have updated CHANGELOG.md
  • (n/a) I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

anton-trunov
anton-trunov previously approved these changes May 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@anton-trunov anton-trunov merged commit baf92bc into tact-lang:main May 7, 2024
3 checks passed
@anton-trunov
Copy link
Member

Cool stuff! Please keep 'em coming :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byakuren-hijiri @anton-trunov