Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix const eval #352

Merged
merged 12 commits into from
Jun 7, 2024
Merged

Fix const eval #352

merged 12 commits into from
Jun 7, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented May 23, 2024 •
edited
Loading

Closes #345 and as result resolves #339 and resolves #327

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.1 milestone May 23, 2024
@Gusarich
Copy link
Member Author

I'm not sure if the .include(...) thing is acceptable for such error messages checks, but it works.

@anton-trunov anton-trunov self-assigned this May 24, 2024
anton-trunov
anton-trunov requested changes May 25, 2024
View reviewed changes
src/test/features/const-eval.tact Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/types/resolveConstantValue.ts Show resolved Hide resolved
@anton-trunov
Copy link
Member

Looks like there is a merge conflict

@Gusarich
Copy link
Member Author

Looks like I've messed up the PR a little bit because of the automatically suggested merging on Github ☹️

@anton-trunov
Copy link
Member

@Gusarich Any progress here?

@Gusarich
Copy link
Member Author

Gusarich commented Jun 6, 2024

@anton-trunov reverted incorrect merge commit and rebased this PR correctly.
Sorry for the delay!

@anton-trunov anton-trunov merged commit 6e1aa01 into tact-lang:main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.1
2 participants
@Gusarich @anton-trunov