Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constructor generation for empty messages #380

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix constructor generation for empty messages #380

merged 2 commits into from
Jun 7, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Jun 6, 2024

Closes #74

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich
Copy link
Member Author

Gusarich commented Jun 6, 2024 •
edited
Loading

Another solution would be to forbid defining messages without fields, like it's done with structs. But I don't think this is a good idea for messages.

@Gusarich Gusarich added this to the v1.3.1 milestone Jun 6, 2024
@anton-trunov anton-trunov self-assigned this Jun 7, 2024
@anton-trunov anton-trunov merged commit c65ec9b into tact-lang:main Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Sending empty message throws at FunC compilation
2 participants
@Gusarich @anton-trunov