Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #402

Merged
merged 16 commits into from
Jun 12, 2024
Merged

Refactor tests #402

merged 16 commits into from
Jun 12, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Jun 11, 2024

Closes #346

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov self-assigned this Jun 11, 2024
@anton-trunov anton-trunov added this to the v1.4.0 milestone Jun 11, 2024
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely massive!

But I wonder if CLI tests are also exported in npm due to package.json#L28. Also, as of now the whole src/ folder is included too. We may want to optimize that, although that's mostly a nitpick.

Description of files field in package.json

image

@Gusarich
Copy link
Member

This is an amazing improvement to the codebase! The tests were a big and not very structured mess that was only getting worse. Now it'll be easier to contribute and resolve merge conflicts in PRs!

Copy link
Member

@Gusarich Gusarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we also remove the feature- prefix from .spec.ts files in e2e tests?

@anton-trunov
Copy link
Member Author

But I wonder if CLI tests are also exported in npm due to package.json#L28.

good point! fixed

Also, as of now the whole src/ folder is included too. We may want to optimize that, although that's mostly a nitpick.

@novusnota can you please open a new issue about it? we should follow the best practices for npm packaging

What if we also remove the feature- prefix from .spec.ts files in e2e tests?

@Gusarich good point as well! done

@anton-trunov anton-trunov merged commit 63f7065 into main Jun 12, 2024
3 checks passed
@anton-trunov anton-trunov deleted the refactor-tests branch June 12, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up Tact's testsuite
3 participants