chore(build): Separate Feature Enabling Function #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byakuren-hijiri
commented
Aug 1, 2024
byakuren-hijiri
force-pushed
the
646-separate-features-fn
branch
from
a1171e2
to
65ee86c
Compare
anton-trunov
reviewed
Aug 1, 2024
There was a problem hiding this comment.
LGTM, but one suggestion though, let's start defining(centralizing) our API in index.ts (see, for instance, https://github.com/ton-org/ton-core/blob/main/src/index.ts). Maybe we can export enableFeatures and build in index.ts to start with. If we do it and add index.ts to Knip's entry points, then we won't have to ignore build.ts (which is the right thing to do).
anton-trunov
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646
I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBERI have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases