fix: always parse a string cell as string #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
assertion `left == right` failed: Mismatch at position (1, 0)
left: Float(-8.086931554011838e18)
right: String("-8086931554011838357")
PrettyWood
force-pushed
the
string-cells
branch
from
d0b2f5b
to
0acc969
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue coming from pola-rs/polars#19169
Comment from #266 (comment) seems to indicate there should not be any reason to try to parse a "str" cell as float since "a formula with a numeric result will be marked with cell type n"
Closes #266