Fix test for ISO-8859-8-I encoding and small refactoring #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDATA section was formed incorrectly and instead was recognized as a Start tag. File introduced in PR tafia#465 and was made manually and not using generator, because WHATWG does not have definition of this encoding as a separate entry in index.json. Actually, this encoding the same as ISO-8859-8, but influences layout direction when render text. Wikipedia: The WHATWG Encoding Standard used by HTML5 treats ISO-8859-8 and ISO-8859-8-I as distinct encodings with the same mapping due to influence on the layout direction So generator was fixed and file regenerated
Mingun
added
the
encoding
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #659 +/- ##
=======================================
Coverage 64.53% 64.54%
=======================================
Files 36 36
Lines 17272 17273 +1
=======================================
+ Hits 11147 11148 +1
Misses 6125 6125
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dralley
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on some future PRs I found a number of mistakes and code smells. The biggest one is an invalid test for ISO-8859-8-I encoding. I noticed, that CDATA section was not a CDATA, because instead of
<![CDATA[I wrote<[[CDATA[[. When I tried to realize, how this would possible, I found that this test file does not generated by test-gen utility, becauseencodings/index.jsondoes not contain a character map for it. This is unnecessary, because this encoding have the same character set as ISO-8859-8, but should be processed slightly differently.