Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return std::io::Error from Writer methods #810

Merged
merged 6 commits into from
Sep 29, 2024
Merged

Commits on Sep 28, 2024

  1. Change Writer errors to only io errors

    The other error types in `crate::errors::Error` are not applicable
    to the Writer. Only io error can be given and putting the io error
    in an `std::sync::Arc` and making users match on all other kinds is
    not needed. The returned `std::io::Error` can still be turned into
    `crate::errors::Error` if needed, but on demand.
    RedPhoenixQ committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    6d47998 View commit details
    Browse the repository at this point in the history
  2. Add ioError to DeError

    This handles Writer now returning `std::io::Error`
    RedPhoenixQ committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    1afe6d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Split SeError from DeError

    This is needed for a larger change of error return values in Writer
    
    Refs: tafia#227
    RedPhoenixQ committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    f0e17be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    41c57d8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    21ec992 View commit details
    Browse the repository at this point in the history
  4. Add changelog entry

    RedPhoenixQ authored and Mingun committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    39b5905 View commit details
    Browse the repository at this point in the history