Track the full paths of attachments in the Attachment object #71
+133
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changing:
Filename
andFilepath
in theAttachment
object.Why this change is being made:
Exit with code 1 due to network error: ContentNotFoundError
- seems to be a PNG file type issue..? #70).--copy-attachments
option) as an absolute path.Related issue(s): Fixes #70
Follow-up changes needed: None AFAIK
Is the change completely covered by unit tests? If not, why not?: No, similarly to converting the attachments path to an absolute path, we are not testing failures of the
filepath.Abs
function.