Workaround to avoid compilation/elaboration error with Cadence Xcelium #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazt81
changed the title
taichi-ishitani
requested changes
Nov 6, 2021
rtl/common/tnoc_packet_if.sv
Outdated
| @@ -42,7 +42,7 @@ interface tnoc_packet_if | |||
| typedef types.tnoc_response_header tnoc_response_header; | |||
| typedef types.tnoc_packed_header tnoc_packed_header; | |||
|
|
|||
| function automatic logic [get_header_width(PACKET_CONFIG)-1:0] pack_header(); | |||
| function automatic tnoc_packed_header pack_header(); | |||
There was a problem hiding this comment.
This code may raise an error caused by DC's bug. We cannot use a type imported from an interface port as a return data type.
4a7dad4#diff-c513451d01469a1d01ef2a1135666ad93be4df19108f5fb0f0665cd29be4fb91
There was a problem hiding this comment.
Cadence Xcelium may have an issue with resolving a function reference at this kind of location so I've uploaded another workaround to add the explicit scope tnoc_pkg::.
env/fabric/top.sv
Outdated
| .i_clk (clk ), | ||
| .i_rst_n (rst_n ), | ||
| .dut_if (flit_if_b2d[i] ), | ||
| .bfm_if (bfm_flit_if_b2d[CHANNELS*i:CHANNELS*(i+1)-1]) |
There was a problem hiding this comment.
Can you add a space before a closing bracket ) to align position of a closing bracket to 2 space tab position?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@taichi-ishitani The 1st change on
env/fabric/top.svis not so good because it means we cannot use modport with multiple interface instances but I heard this is the only solution to elaborate this kind of code with Xcelium.The 2nd change on
rtl/common/tnoc_packet_if.svis what you wanted to do here but you didn't do so. I think it may cause some problem with Synopsys VCS. I'd like to hear your opinion on this.