fix(kit): Number incorrectly shift caret for 1st time insertion into textfield with initial value
#1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extfield with initial value
nsbarsukov
requested review from
waterplea,
splincode,
vladimirpotekhin and
mdlufy
|
Visit the preview URL for this PR (updated for commit 424365b): https://maskito--pr1792-number-fix-udgfleok.web.app (expires Tue, 22 Oct 2024 14:50:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 61e4dea776cbea516b68c67840913d2edd88bb90 |
nsbarsukov
commented
Oct 21, 2024
| prefix, | ||
| postfix, | ||
| thousandSeparator: ' ', | ||
| describe('with prefix & postfix', () => { |
There was a problem hiding this comment.
Tests inside this describe were not changed (just a new tabulation)
nsbarsukov
commented
Oct 21, 2024
| }); | ||
|
|
||
| it('$6 4|32 kg => Delete => $64|2 kg', () => { | ||
| it('123 45|6 789 => Type 0 (the 1st time input event) => 1 234 50|6 789', () => { |
nsbarsukov
commented
Oct 21, 2024
Comment on lines
-194
to
+196
| .should('have.prop', 'selectionStart', '00'.length) | ||
| .should('have.prop', 'selectionEnd', '00'.length) | ||
| .should('have.prop', 'selectionStart', '0'.length) | ||
| .should('have.prop', 'selectionEnd', '0'.length) |
There was a problem hiding this comment.
It was invalid assertion
waterplea
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1787