Add --keep-going flag #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
keep-going
branch
3 times, most recently
from
5ad500f
to
b0fc069
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 29, 2021
140: Add --keep-going flag r=taiki-e a=taiki-e Closes #133 <img width="1046" alt="keep-going" src="https://user-images.githubusercontent.com/43724913/147629433-3d58a94a-cd7b-4ed1-8932-ef30d2fce46b.png"> Co-authored-by: Taiki Endo <[email protected]>
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Dec 29, 2021
141: Do not add --all-features to combinations if it is already covered by another combination r=taiki-e a=taiki-e This fixes an issue where `--feature-powerset` and `--each-feature` add `--all-features` as one of the combinations, even if it is already covered by another combination. (The initial work on this fix was included in #140.) Hopefully, the new behavior should be explained almost exactly in the long help message. https://github.com/taiki-e/cargo-hack/blob/4234b37e670368067b64dba249ac41616fe2da85/tests/long-help.txt#L30-L37 https://github.com/taiki-e/cargo-hack/blob/4234b37e670368067b64dba249ac41616fe2da85/tests/long-help.txt#L39-L47 Follow-up: #42 Co-authored-by: Taiki Endo <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133