Run with --all-features first, run with biggest feature combination early (first or second) if --all-features case is skipped #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #246
The first and third commits are directly related to this behavior; the second commit is a fix to the related behavior.
--all-features case: --all-features case moved from the last to the first
From:
To:
non --all-features case: the biggest feature combination case (in this case, default,easytime) moved from the last to the second (last -> first when --exclude-no-default-features passed)
From:
To:
The reason it is not always run first is that there is no good way to implement it other than duplicating the code in 3 places or moving the "--no-default-features without --features" case to the last (I don't want to move it to the last because that is another "case where it is likely to find a problem").