-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin clap to ~3.1 #185
Pin clap to ~3.1 #185
Conversation
log
|
``` error: failed to download `clap_lex v0.2.2` Caused by: unable to get packages from source Caused by: failed to parse manifest at `/home/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/clap_lex-0.2.2/Cargo.toml` Caused by: feature `edition2021` is required this Cargo does not support nightly features, but if you switch to nightly channel you can add `cargo-features = ["edition2021"]` to enable this feature ```
bors r+ |
Build succeeded: |
@@ -28,7 +28,7 @@ anyhow = "1.0.34" | |||
atty = "0.2.11" | |||
camino = "1.0.3" | |||
cargo_metadata = "0.14" | |||
clap = { version = "3.1", features = ["derive"] } | |||
clap = { version = "~3.1", features = ["derive"] } # https://github.com/clap-rs/clap/issues/3822 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.
btw is there a reason this project doesn't check-in the Cargo.lock
? Generally, it is recommended to do so for programs and that would have prevented the unintended upgrade rather than needing to pin the dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can now be reverted as deprecations are now off by default, see clap-rs/clap#3830 for details. When you do start working through the deprecations as part of upgrading to 4.0, we've also improved the warnings for derive users. See clap-rs/clap#3832 for examples.
Nice! Thanks for working on this problem!
btw is there a reason this project doesn't check-in the
Cargo.lock
? Generally, it is recommended to do so for programs and that would have prevented the unintended upgrade rather than needing to pin the dependency.
This is intentional. See #152 (comment) for details.
187: Unpin clap version r=taiki-e a=taiki-e See #185 (comment) Co-authored-by: Taiki Endo <[email protected]>
Derive macro receives a lot of deprecated warnings.
Refs: clap-rs/clap#3822