Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will it fail if a changelog doesn't have the right version? #22

Closed
lmajano opened this issue Mar 20, 2023 · 2 comments · Fixed by #23
Closed

Will it fail if a changelog doesn't have the right version? #22

lmajano opened this issue Mar 20, 2023 · 2 comments · Fixed by #23
Labels
question Further information is requested

Comments

@lmajano
Copy link
Contributor

lmajano commented Mar 20, 2023

Will the build step fail if you specify a changelog.md but the tag you are building is not in the file?

Is there a way, to allow it to pass even if the changelog doesn't contain the tag version?

@taiki-e
Copy link
Owner

taiki-e commented Mar 20, 2023

In the current implementation, if the changelog option is specified, an entry corresponding to the version must be present in the changelog.

That said, I think it would be easy to add an option to allow cases where the corresponding changelog entry is missing.
Probably it needs to change the following line to return an empty string if the option to allow missing entry is set.

notes=$(./parse-changelog "${parse_changelog_options[@]}")

Something like:

if [[ -n "${INPUT_ALLOW_MISSING_CHANGELOG_ENTRY:-}" ]]; then
    notes=$(./parse-changelog "${parse_changelog_options[@]}" || echo "") 
else
    notes=$(./parse-changelog "${parse_changelog_options[@]}") 
fi

@taiki-e taiki-e added the question Further information is requested label Mar 20, 2023
@lmajano
Copy link
Contributor Author

lmajano commented Mar 21, 2023

I went ahead and did this and sent you a PR: #23

Great docs and app layout. It was easy to get in, make changes, and collaborate. I wish all open-source projects were like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants