Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new input allow_missing_changelog:boolean #23

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

lmajano
Copy link
Contributor

@lmajano lmajano commented Mar 21, 2023

  • Added new input allowMissingChangelog:boolean that will allow the build to continue to run even though the targeted version was not found on the changelog file. The default of this input is false to stay backward compatible.

Closes #22

… build to continue to run even though the targeted version was not found on the changelog file. The default of this input is `false` to stay backwards compatible.
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

main.sh Outdated Show resolved Hide resolved
@lmajano
Copy link
Contributor Author

lmajano commented Mar 22, 2023

Updates done as per your PR

@taiki-e taiki-e changed the title Added new input allowMissingChangelog:boolean Added new input allow_missing_changelog:boolean Mar 22, 2023
@taiki-e taiki-e merged commit 34d3d3b into taiki-e:main Mar 22, 2023
@taiki-e
Copy link
Owner

taiki-e commented Mar 22, 2023

Published in v1.7.0 as allow-missing-changelog input option.

Note that it was renamed from snake_case(allow_missing_changelog) to kebab-case (allow-missing-changelog) before release. This is because of the consistency of API with the existing computed-prefix output option, which is kebab-case.

@lmajano
Copy link
Contributor Author

lmajano commented Mar 22, 2023 via email

@lmajano
Copy link
Contributor Author

lmajano commented Oct 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will it fail if a changelog doesn't have the right version?
2 participants