Switch to composite action #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A potential concern regarding this is compatibility with older self-hosted runners. Composite action was added on 2020-08-07, but it probably requires 2.290.0 (2022-04-13) or 2.295.0 (2022-08-10) for this action to actually work properly in the composite action on the self-hosted runners. |
taiki-e
force-pushed
the
composite-action
branch
from
c0c767a
to
367715e
Compare
|
Given that it has been 6 months since the release of runner, which is expected to work, and that node 16 will be EoL in about 6 more months, I think this is a reasonable time to merge this. |
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switching is needed to implement the idea said in #54 (comment). (To actually do it, we also need to address the cache-cargo-install-action's limitation that cannot specify multiple crates in a single action call, though.)
I tried this twice in the past and gave up due to actions/runner#665 and actions/runner#2185, respectively, and eventually was able to work around these problems when implementing cache-cargo-install-action.