Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the span of self argument #250

Merged
merged 1 commit into from
Jun 8, 2020
Merged

Preserve the span of self argument #250

merged 1 commit into from
Jun 8, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jun 8, 2020

Refs: dtolnay/async-trait#105

#[pinned_drop] attribute also has same issue.

@taiki-e taiki-e added A-drop Area: #[pinned_drop] and Drop relnotes labels Jun 8, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Jun 8, 2020

bors r+

bors bot added a commit that referenced this pull request Jun 8, 2020
250: Preserve the span of self argument r=taiki-e a=taiki-e

Refs: dtolnay/async-trait#105

`#[pinned_drop]` attribute also has same issue.

Co-authored-by: Taiki Endo <[email protected]>
@taiki-e

This comment has been minimized.

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 8, 2020

@bors

This comment has been minimized.

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 8, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 8, 2020

Build succeeded:

@bors bors bot merged commit b711e11 into master Jun 8, 2020
@bors bors bot deleted the self branch June 8, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-drop Area: #[pinned_drop] and Drop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant