Xcalloptions refactor #19
Conversation
| let version = u16::from_be_bytes(input[0..2].try_into().unwrap()); | ||
| let chain_id = u64::from_be_bytes(input[2..10].try_into().unwrap()); | ||
| println!("chain_id: {:?}", chain_id); |
There was a problem hiding this comment.
ah confusing diff because it seems you didn't pull my commit
| let mut prefix = b"XCallOptions".to_vec(); | ||
| prefix.extend_from_slice(&input); | ||
|
|
||
| Ok(PrecompileOutput::new(0, Bytes::copy_from_slice(&prefix))) |
There was a problem hiding this comment.
The value can be easily fixed in something like the identity precompile where if you would send this input it gets copied to the output and then revm would also pick it up as call options, which would be bad.
The output also impacts the actual return value inside the EVM, so not ideal because can increase gas costs (though maybe not if it's not read, not sure with precompiles), ideally this data is not exposed to the actual EVM.
There was a problem hiding this comment.
i know i know
just a temp solution, I'm gonna directly change PrecompileOutput into a enum or something
| memory_offset, | ||
| call_options: interpreter_result.call_options, |
There was a problem hiding this comment.
Already in result so no separate field necessary?
| // env.tx.caller is the Signer of the transaction | ||
| // caller is the address of the contract that is calling the precompile | ||
| if tx_origin != env.tx.caller.1 || msg_sender != caller.1 { | ||
| return Err(Error::XCallOptionsInvalidInputLength.into()); |
There was a problem hiding this comment.
| return Err(Error::XCallOptionsInvalidInputLength.into()); | |
| return Err(Error::XCallOptionsInvalidOrigin.into()); |
CeciliaZ030
force-pushed
the
xcalloptions-refactor
branch
from
9068dd5
to
5907abe
Compare
No description provided.