chore(bridge-ui): follow JS convention for method name #13430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: shadab-taiko <[email protected]>
Co-authored-by: shadab-taiko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #13430 +/- ##
==========================================
- Coverage 35.55% 34.76% -0.79%
==========================================
Files 122 122
Lines 3741 3693 -48
Branches 497 497
==========================================
- Hits 1330 1284 -46
+ Misses 2320 2318 -2
Partials 91 91
*This pull request uses carry forward flags. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
previously approved these changes
Mar 23, 2023
dionysuzx
previously approved these changes
Mar 23, 2023
shadab-taiko
previously approved these changes
Mar 24, 2023
jscriptcoder
dismissed stale reviews from shadab-taiko, dionysuzx, and dantaik
via
6277e50
dionysuzx
approved these changes
Mar 27, 2023
adaki2004
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be consistent let's follow some basic conventions regarding function naming. What I'm saying here is that this is no Go lang 😉