Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): reduce MainnetTaikoL1 code size #17792

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 14, 2024

MainnetTaikoL1's code is too large. In this PR, I changed a library function to public, added back TaikoEvents (otherwise client cannot handle public library events), and changed deploy scripts to test deploying MainnetTaikoL1.

@dantaik dantaik marked this pull request as ready for review July 14, 2024 03:53
@dantaik dantaik enabled auto-merge July 14, 2024 03:53
Copy link

openzeppelin-code bot commented Jul 14, 2024

fix(protocol): reduce MainnetTaikoL1 code size

Generated at commit: bdeaa522d32ce3ca8a672135cc492a81284497a4

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik requested a review from Brechtpd July 14, 2024 09:32
@dantaik dantaik added this pull request to the merge queue Jul 14, 2024
Merged via the queue into main with commit 45281b8 Jul 14, 2024
6 checks passed
@dantaik dantaik deleted the reduce_contract_size branch July 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants