Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add virtual file system #1142

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

mogery
Copy link
Contributor

@mogery mogery commented Feb 7, 2024

Summary:
This PR adds a virtual file system to execution_spec, much like described in #1137.

Issue Reference(s):
Fixes #1137
/claim #1137

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Feb 7, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e7644d) 88.29% compared to head (c472dfa) 88.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   88.29%   88.28%   -0.01%     
==========================================
  Files         105      105              
  Lines       11583    11583              
==========================================
- Hits        10227    10226       -1     
- Misses       1356     1357       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mogery
Copy link
Contributor Author

mogery commented Feb 7, 2024

Screenshot 2024-02-07 at 20 16 21

codecov being weird again

@tusharmath tusharmath changed the title feat(execution_spec): add virtual file system chore(test): add virtual file system Feb 8, 2024
@tusharmath tusharmath enabled auto-merge (squash) February 8, 2024 06:37
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Feb 8, 2024
@tusharmath tusharmath merged commit 81198a9 into tailcallhq:main Feb 8, 2024
13 of 14 checks passed
@mogery mogery deleted the mog/execution-spec-vfs branch February 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support files in Spec
2 participants